Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does not work (out of the box) in a minified app #108

Open
TWiStErRob opened this issue Mar 9, 2024 · 1 comment
Open

Does not work (out of the box) in a minified app #108

TWiStErRob opened this issue Mar 9, 2024 · 1 comment

Comments

@TWiStErRob
Copy link
Member

Exception in thread "main" kotlinx.serialization.SerializationException: Serializer for class 'SarifSchema210' is not found.
Mark the class as @Serializable or provide the serializer explicitly.
        at kotlinx.serialization.internal.Platform_commonKt.serializerNotRegistered(Platform.common.kt:91)
        at kotlinx.serialization.internal.PlatformKt.platformSpecificSerializerNotRegistered(Platform.kt:29)
        at kotlinx.serialization.SerializersKt__SerializersKt.serializer(Serializers.kt:60)
        at kotlinx.serialization.SerializersKt.serializer(Unknown Source)
        at io.github.detekt.sarif4k.SarifSerializer.toJson(SarifSerializer.kt:23)

The proguard/r8 rules actually exist in https://github.com/Kotlin/kotlinx.serialization/blob/master/rules/common.pro, but only since 1.5.

#43 would solve this immediately, workaround:

implementation("io.github.detekt.sarif4k:sarif4k:0.5.0")
implementation("org.jetbrains.kotlinx:kotlinx-serialization-json:1.6.3")
TWiStErRob added a commit to TWiStErRob/net.twisterrob.ghlint that referenced this issue Mar 9, 2024
@BraisGabin
Copy link
Member

We could update it to the latest version, or 1.5.0 at least. We are at 0. version so this shouldn't be a huge problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants