Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Abort running command, if App.Close() is called #6

Open
skaldesh opened this issue Aug 31, 2019 · 4 comments
Open

Abort running command, if App.Close() is called #6

skaldesh opened this issue Aug 31, 2019 · 4 comments
Labels

Comments

@skaldesh
Copy link
Member

Right now, it is not possible to properly close the application, since the Run() command runs the shell and waits for the next readline() to finish. This requires that, if the App has been closed from outside, the user still needs to press enter in order for the close to succeed

@r0l1
Copy link
Member

r0l1 commented Nov 20, 2019

grumble/app.go

Line 324 in 39c3b8e

a.OnClose(a.rl.Close)

Changing this to OnClosing might fix this.

@lewisthompson
Copy link

Unfortunately the above suggestion does not work.

@skaldesh
Copy link
Member Author

Things probably change anyway with #15

@skaldesh skaldesh added the bug label Feb 18, 2020
@skaldesh
Copy link
Member Author

skaldesh commented Oct 5, 2020

If #15 does not get merged, we should look for another opportunity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants