Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in DPUB allowed roles alborithm #4434

Open
WilcoFiers opened this issue Apr 29, 2024 · 1 comment
Open

Bug in DPUB allowed roles alborithm #4434

WilcoFiers opened this issue Apr 29, 2024 · 1 comment
Labels
fix Bug fixes

Comments

@WilcoFiers
Copy link
Contributor

This line is wrong:

if (dpubRoles.includes(role) && getRoleType(role) !== implicitRole) {

Didn't look too closely, but getRoleType doesn't return an implicit role. This cannot be correct.

@WilcoFiers WilcoFiers added the fix Bug fixes label Apr 29, 2024
@danielweck
Copy link

I think this may be the reason why we are now seeing false negatives in DAISY Ace (I am in the process of integrating the latest version of Deque Axe, 4.9.1 as of today). Though I suspect we will need to migrate to 4.10.0 as soon as available due to landmark-unique bugs. I will report any of my findings here. Thanks for your hard work team Axe!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Bug fixes
Projects
None yet
Development

No branches or pull requests

2 participants