Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All pull requests have 'across 1 directory' in the title since today #9631

Open
1 task done
mvz opened this issue Apr 29, 2024 · 5 comments
Open
1 task done

All pull requests have 'across 1 directory' in the title since today #9631

mvz opened this issue Apr 29, 2024 · 5 comments
Labels
F: grouped-updates 🎳 Relates to bumping more than one dependency in a single PR L: ruby:bundler RubyGems via bundler T: bug 🐞 Something isn't working

Comments

@mvz
Copy link

mvz commented Apr 29, 2024

Is there an existing issue for this?

  • I have searched the existing issues

Package ecosystem

bundler

Package manager version

No response

Language version

No response

Manifest location and content before the Dependabot update

No response

dependabot.yml content

For example, https://github.com/Docbldr/docbldr-use-demo/blob/2502f361346f5b7394fb8cb1804e58c32d422439/.github/dependabot.yml

Updated dependency

selenium-webdriver from 4.19.0 to 4.20.1, and many other cases in all of our repositories

What you expected to see, versus what you actually saw

I expected to see a pull request title 'Bump selenium-webdriver from 4.19.0 to 4.20.1 in the development-dependencies group'.

Instead the pull request title is 'Bump selenium-webdriver from 4.19.0 to 4.20.1 in the development-dependencies group across 1 directory'. (See https://github.com/Docbldr/docbldr-use-demo/pull/3029).

Since there is only one directory with dependency information, this extra text is superfluous.

The same issue happens in all of the pull requests created by dependabot since today.

Native package manager behavior

No response

Images of the diff or a link to the PR, issue, or logs

No response

Smallest manifest that reproduces the issue

No response

@mvz mvz added the T: bug 🐞 Something isn't working label Apr 29, 2024
@github-actions github-actions bot added L: git:submodules Git submodules L: ruby:bundler RubyGems via bundler labels Apr 29, 2024
@abdulapopoola
Copy link
Member

Hi @mvz , that is because we shipped multi-dir support. We can look at improving this, tagging @carlincherry

@corneliusroemer
Copy link

corneliusroemer commented Apr 30, 2024

I opened a duplicate before discovering this issue. While multi-dir support might be nice, it's important to special case the single-dir case for PR titles as this will likely remain the most common use case.

In a normal repo with multiple groups configured, the current change makes things much less user friendly.

I'm repeating my PR content as it might be easier to understand the issue at first glance than in OP's summary:

It appears that around 18 hours ago (2024-04-29 20:00 UTC) grouped dependabot PR titles became more generic, less specific as follows:

Old: chore(deps): bump the minorandpatch group in /website with 16 updates

New: chore(deps): bump the minorandpatch group across 1 directory with 16 updates

Note: the specific and informative in /website got replaced with the generic across 1 directory making it much harder to tell at a glance what's impacted.

@mvz
Copy link
Author

mvz commented May 1, 2024

@corneliusroemer I'm not sure your case is exactly the same since in the old pull request title I did not have any directory specification like 'in /website'. All my directories are "/".

@corneliusroemer
Copy link

@mvz you are right! In your case it's just extra noise, in my case it's loss of crucial information. I might reopen.

@abdulapopoola abdulapopoola added F: grouped-updates 🎳 Relates to bumping more than one dependency in a single PR and removed L: git:submodules Git submodules labels May 1, 2024
@mvz
Copy link
Author

mvz commented May 13, 2024

I should add that this happens intermittently. Dependabot just now even closed PRs without 'across 1 directory' and opened new ones including the offending phrase.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
F: grouped-updates 🎳 Relates to bumping more than one dependency in a single PR L: ruby:bundler RubyGems via bundler T: bug 🐞 Something isn't working
Projects
Status: No status
Development

No branches or pull requests

3 participants