Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug - va-search-input suggestion box doesn't close #2795

Open
3 tasks
micahchiang opened this issue May 2, 2024 · 0 comments
Open
3 tasks

Bug - va-search-input suggestion box doesn't close #2795

micahchiang opened this issue May 2, 2024 · 0 comments
Labels
bug Something isn't working dst-engineering Issues that require work from Design System Team engineers platform-design-system-team

Comments

@micahchiang
Copy link
Contributor

Description

We recently added a fix for va-search-input that resolved an issue sitewide was having, but inadvertently added a regression where the suggestion box stays open.

This is likely because isTouched is never reset to false, and needs to be. Possibly in the handleBlur function.

Screen cap

Private Zenhub Video

Considerations

Tasks

  • Fix suggestion box
  • Test locally in vets-website

Acceptance Criteria

  • above tasks have been completed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working dst-engineering Issues that require work from Design System Team engineers platform-design-system-team
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@micahchiang