Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Troubleshoot issues with Chromatic CI check #2785

Open
it-harrison opened this issue Apr 26, 2024 · 2 comments
Open

Troubleshoot issues with Chromatic CI check #2785

it-harrison opened this issue Apr 26, 2024 · 2 comments

Comments

@it-harrison
Copy link
Contributor

Sometimes the Chromatic CI check will generate diffs based on a commit in a PR that is not the most recent; the effect of this is that diffs can be flagged incorrectly and re-running the build does not always fix this problem. When this happens a PR cannot move forward unless the diffs are accepted (when they should not be), meaning that the next PR will have to deal with accepting changes that return the baseline where it should be. This behavior also makes it hard to determine the visual effect of a PR on other components.

@jamigibbs
Copy link
Contributor

jamigibbs commented May 1, 2024

Thank you for this issue @it-harrison!

Dan started a Slack thread here about nailing down a review process that we might want to do as a follow-up to this issue too.

@jamigibbs
Copy link
Contributor

Something that I noticed is that branches merged into main seem to need to Chromatic changes accepted again even after they have already been accepted in the merging branch. That might be related.

Screenshot 2024-05-01 at 9 50 19 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants