Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Figma rebuild: Templates - Form Step (pattern) #2778

Closed
8 tasks
LWWright7 opened this issue Apr 25, 2024 · 6 comments
Closed
8 tasks

Figma rebuild: Templates - Form Step (pattern) #2778

LWWright7 opened this issue Apr 25, 2024 · 6 comments
Assignees
Labels

Comments

@LWWright7
Copy link

Description

There were many templates created in Sketch that will need to be included in Figma. This has a few different things to consider that would be good to get Designer feedback on.

  • What templates to include in Figma?

  • What breakpoints are needed?

  • Should these templates be in the Figma library or somewhere else?

  • Templates page

Details

Tasks

Figure out

  • What templates that we will need in Figma
  • Breakpoints for templates
  • Where will the templates live
  • Create templates and add to Figma

Acceptance Criteria

The design is the same as what is in the Component Symbol Library in Sketch. If

  • Reviewed by other DS designer
  • Possibly review with VFS Designers
  • Review by PO

Rachel created step components for forms that includes sub-patterns (address, buttons, questions, etc)

those components can be found in Figma here:

https://www.figma.com/file/4A3O3mVx4xDAKfHE7fPF1U/VADS-Templates%2C-Patterns%2C-and-Forms?type=design&node-id=112%3A11074&mode=design&t=InY5ntX0zJYHwDHc-1

@caw310 caw310 transferred this issue from department-of-veterans-affairs/va.gov-team Apr 25, 2024
@caw310
Copy link
Contributor

caw310 commented Apr 25, 2024

Hey team! Please add your planning poker estimate with Zenhub @babsdenney @danbrady @LWWright7

@caw310 caw310 added pattern-update Change to an existing pattern Figma labels Apr 25, 2024
@LWWright7
Copy link
Author

@caw310 - I know this wasn't in this sprint, but it needed to be done to facilitate the work I'm doing with #2545 so I figured we might as well get credit for it in this sprint.

@danbrady @babsdenney this is ready for review here. thanks!

@caw310 caw310 added the new-unplanned Unplanned work added to a sprint label Apr 30, 2024
@LWWright7
Copy link
Author

This ticket will carryover because I was out sick Mon-Tues of this week. However, this work was NOT planned for this sprint and was brought in as a dependency for other work.

@caw310 caw310 removed the new-unplanned Unplanned work added to a sprint label May 9, 2024
@LWWright7
Copy link
Author

@babsdenney @danbrady - This one is ready for another review! thanks

@danbrady
Copy link
Contributor

LGTM!

@LWWright7
Copy link
Author

Thanks @danbrady !!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants