-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace content-build breadcrumb partial with V3 Component #2742
Replace content-build breadcrumb partial with V3 Component #2742
Comments
Same here, cc @FranECross @randimays @chriskim2311 for outcome from the Breadcrumbs spike on V3 component migration. Facilities will handle this work, and I've added an AC here to make sure PW is looped into code review for testing PW products. |
It seems this is a dupe based on Matthew Dingee's comment here: department-of-veterans-affairs/va.gov-cms#14724 (comment) Am I misunderstanding? |
This is part 2 of breadcrumb component update that Facilities will be doing with Public Websites, Design System, and Forms teams reviews. |
TODO: @jilladams slack DS on thread to notify re: slipped timing |
Hey team! Please add your planning poker estimate with Zenhub @Andrew565 @ataker @harshil1793 @it-harrison @jamigibbs @micahchiang @nickjg231 @powellkerry @rmessina1010 @rsmithadhoc |
This work has been completed in the above PR, just waiting on sitewide to approve. |
Closing this ticket since the work is technically complete. We've created #2868 and #2869 which address some things flagged in the original code review. More context in this conversation |
User Story or Problem Statement
The breadcrumbs component in
content-build
will be converted to the V3 component. This ticket is for making the official transition to the component.This ticket is blocked by #2741.
The current component updated deadline is May 3.
Description or Additional Context
content-build
breadcrumbs do not do this. This is an intentional and expected change.div
wrapper with additional padding to ensure it keeps the same layoutSteps for Implementation
breadcrumb-list
array that will be passed into the component.<VaBreadcrumbs>
and pass in thebreadcrumb-list
along with any other needed arguments.div
wrapper to keep the layout and placement as consistent as possible with the previous breadcrumbs.Acceptance Criteria
The text was updated successfully, but these errors were encountered: