Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace content-build breadcrumb partial with V3 Component #2742

Closed
12 tasks
maxx1128 opened this issue Mar 5, 2024 · 9 comments · May be fixed by department-of-veterans-affairs/content-build#2095
Closed
12 tasks
Assignees
Labels

Comments

@maxx1128
Copy link

maxx1128 commented Mar 5, 2024

User Story or Problem Statement

The breadcrumbs component in content-build will be converted to the V3 component. This ticket is for making the official transition to the component.

This ticket is blocked by #2741.

The current component updated deadline is May 3.

Description or Additional Context

  • The "current link" at the end of breadcrumbs will appear as a visible link, while the current content-build breadcrumbs do not do this. This is an intentional and expected change.
  • The component may need to be placed in a div wrapper with additional padding to ensure it keeps the same layout

Steps for Implementation

  • Use the new filter created in Move content-build's breadcrumbs liquid logic to a liquid filter #2741 to create the breadcrumb-list array that will be passed into the component.
  • Replace the HTML markup in the component with <VaBreadcrumbs> and pass in the breadcrumb-list along with any other needed arguments.
  • If needed, add extra padding to a div wrapper to keep the layout and placement as consistent as possible with the previous breadcrumbs.

Acceptance Criteria

  • Implementation steps are completed
  • Current tests and coverage are reviewed and if any new or updated tests are needed, that is noted
  • Thorough QA testing is done on a wide variety of pages to properly assess impact and catch potential bugs
  • @department-of-veterans-affairs/vfs-public-websites-frontend is added as a code reviewer on related PRs
  • @micahchiang from Design System Team is added as a code reviewer on related PRs.
  • @ndsprinkle from Forms Team is added as a code reviewer on related PRs.
  • Requires design review
  • Requires accessibility review
  • Tag PM to implement change management in collaboration with Design System Team.
@jilladams
Copy link

Same here, cc @FranECross @randimays @chriskim2311 for outcome from the Breadcrumbs spike on V3 component migration. Facilities will handle this work, and I've added an AC here to make sure PW is looped into code review for testing PW products.

@randimays
Copy link

It seems this is a dupe based on Matthew Dingee's comment here: department-of-veterans-affairs/va.gov-cms#14724 (comment) Am I misunderstanding?

@xiongjaneg
Copy link

This is part 2 of breadcrumb component update that Facilities will be doing with Public Websites, Design System, and Forms teams reviews.

@xiongjaneg
Copy link

Per Matt Dingee with Design System, we have until May 3rd

@jilladams
Copy link

TODO: @jilladams slack DS on thread to notify re: slipped timing

@caw310
Copy link
Contributor

caw310 commented Apr 18, 2024

@jilladams
Copy link

@caw310 thanks for moving this over! I don't have the power to change epics on it anymore -- would you mind removing the 2 Epics it was in before the move? (Same on #2741 )

@Andrew565
Copy link
Contributor

This work has been completed in the above PR, just waiting on sitewide to approve.

@caw310 caw310 removed the Stretch Stretch goals label May 23, 2024
@micahchiang
Copy link
Contributor

Closing this ticket since the work is technically complete. We've created #2868 and #2869 which address some things flagged in the original code review. More context in this conversation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants