Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add number input functionality to text input #2613

Open
4 tasks
micahchiang opened this issue Mar 21, 2024 · 1 comment
Open
4 tasks

Add number input functionality to text input #2613

micahchiang opened this issue Mar 21, 2024 · 1 comment
Labels

Comments

@micahchiang
Copy link
Contributor

micahchiang commented Mar 21, 2024

Description

In order to deprecate number input in favor of using text input, any existing number input functionality that doesn't already exist in text input needs to be migrated over. A brief look at va-number-input suggests that we'll need to move:

  • inputmode?: 'decimal' | 'numeric'
  • min and max number values
  • currency

We may want to reuse the regex pattern currently used in va-number-input.

Considerations

  • existing number input tests can likely be modified and reused for the extended text input

Tasks

  • Add non-overlapping number input functionality to text input
  • Update text input tests
  • Update number input storybook entry with messaging about upcoming deprecation

Acceptance Criteria

  • Above tasks have been completed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants