Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Formation Deprecation - Typography base size migration QA component-library #2566

Closed
4 tasks
micahchiang opened this issue Mar 6, 2024 · 6 comments · May be fixed by department-of-veterans-affairs/component-library#1096
Assignees
Labels
dst-engineering Issues that require work from Design System Team engineers platform-design-system-team

Comments

@micahchiang
Copy link
Contributor

micahchiang commented Mar 6, 2024

Description

In addition to #2494, #2525, and #2431, we need to ensure the formation overrides in component-library are properly scaled so visual parity is maintained on VA.gov.

QA needs to be conducted in vets-website prior to any pull request being merged in. This likely means local testing and sandbox testing with the preview instance that gets generated when a pull request is submitted to vets-website and content-build.

Considerations

  • Pull request into formation. This should ultimately bump the version number for Formation as well.
  • Pull request into vets-website. This should include the version change from the above PR, and QA should be conducted using the preview instance and/or verdaccio.
  • component library formation overrides
  • Some components, such as va-accordion-item also declare rem values directly in their respective stylesheets. These need to be updated as well.

Tasks

  • Conduct QA on vets-website PR above
  • Scale any rem values in component library that need to be scaled
  • Merge PRs into vets-website and content-build

Acceptance Criteria

  • Above tasks have been completed
@micahchiang micahchiang added dst-engineering Issues that require work from Design System Team engineers platform-design-system-team labels Mar 6, 2024
@micahchiang micahchiang changed the title Copy of Formation Deprecation - Typography base size migration QA vets-website and content-build Formation Deprecation - Typography base size migration QA component-library Mar 6, 2024
@caw310
Copy link
Contributor

caw310 commented Mar 7, 2024

@jamigibbs
Copy link
Contributor

The _formation_overrides.scss stylesheet will need to be removed as part of this work:

https://github.com/department-of-veterans-affairs/component-library/blob/main/packages/web-components/src/global/_formation_overrides.scss

This stylesheet is what we used to "correct" the old Formation base font size.

@caw310
Copy link
Contributor

caw310 commented Mar 7, 2024

More than one engineer will work on this effort.

@powellkerry
Copy link
Contributor

component-library branch: 66753-formation-typography

@powellkerry
Copy link
Contributor

This will carry over due to delays in the Formation QA ticket. A PR should be spun up in the next couple of days and this ticket should be closed soon after.

@powellkerry
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dst-engineering Issues that require work from Design System Team engineers platform-design-system-team
Projects
None yet
6 participants