Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate breadcrumbs liquid template to breadcrumbs web component #2560

Closed
2 tasks
micahchiang opened this issue Mar 5, 2024 · 1 comment
Closed
2 tasks
Labels
dst-engineering Issues that require work from Design System Team engineers platform-design-system-team va-breadcrumb DS Breadcrumb component

Comments

@micahchiang
Copy link
Contributor

Description

If an application in the content-build registry.json file includes breadcrumbs, then it'll use the liquid template provided in content-build found here.

Of the 109 application entries in that registry file, there are 47 applications explicitly setting includeBreadcrumbs: true and 5 which set that property to false. So a little under 50% look to be using the aforementioned liquid template.

All instances that don't have the includeBreadcrumbs flag, or set it to false, are likely using a web component to manage their breadcrumbs.

We need to update this template to use the va-breadcrumbs web component instead of the unordered list it currently uses.

Considerations

  • Testing this will probably mean running the static pages for vets-website. Directions for how to run those can be found here.

Tasks

  • replace the unordered list in the liquid template above with the va-breadcrumbs component and verify it functions as expected

Acceptance Criteria

  • Tasks have been completed.
@humancompanion-usds
Copy link
Collaborator

Sitewide is going to handle this change here:
#2741

We'll assist in whatever way they need.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dst-engineering Issues that require work from Design System Team engineers platform-design-system-team va-breadcrumb DS Breadcrumb component
Projects
None yet
Development

No branches or pull requests

2 participants