Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal on improving "func shouldRetry(err error)" #70

Open
chainone opened this issue Aug 13, 2016 · 1 comment
Open

Proposal on improving "func shouldRetry(err error)" #70

chainone opened this issue Aug 13, 2016 · 1 comment

Comments

@chainone
Copy link
Contributor

I am thinking, for http errors, we may be able to check the status code to see if the request is retry-able. We have no reason to retry a request with status code 400, 403, 404.

However, as we have so many http status codes, it may be hard to check every code to tell if it is retry-able or not. I could not find any document about those http codes that are not retry-able.

Let me know if you have any comments, thanks.

@denverdino
Copy link
Owner

I agree. We need some revisit for the shouldRetry impl

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants