Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use reqwest_middleware lib to allow adding HTTP middleware. #23516

Open
maxmcd opened this issue Apr 23, 2024 · 2 comments
Open

Use reqwest_middleware lib to allow adding HTTP middleware. #23516

maxmcd opened this issue Apr 23, 2024 · 2 comments

Comments

@maxmcd
Copy link

maxmcd commented Apr 23, 2024

Hi, I was curious if there was interest to replace the reqwest::Client use in the codebase with reqwest_client::ClientWithMiddleware too allow for adding things like tracing and other middleware analysis to Deno network requests. This is not from the position of an end user using Deno, I am using Deno as a Rust library. I'm looking to get better visibility into network requests and debugging of import requests.

I am already doing this work, but wanted to see if it could be upstreamed. So far it doesn't seem too invasive.

Thanks!

@bartlomieju
Copy link
Member

Feel free to open a PR, though I must warn you that we've had internal discussions about moving away from reqwest. Not sure about the timeline though :)

@maxmcd
Copy link
Author

maxmcd commented Apr 24, 2024

Thanks @bartlomieju, sounds good. Happy to work with whatever the successor is if reqwest is replaced.

I've opened a PR here: #23539

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants