Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for nested blueprint books #68

Open
kellbot opened this issue Jul 1, 2023 · 3 comments
Open

Support for nested blueprint books #68

kellbot opened this issue Jul 1, 2023 · 3 comments

Comments

@kellbot
Copy link
Contributor

kellbot commented Jul 1, 2023

Not sure if this is something you've already worked on, but I had a need for nested blueprint books so I added support for it in my fork of the project: https://github.com/kellbot/factorio-blueprint/tree/nested_books

I also have another branch that supports blueprint names (among other additions) but I don't have a way to set up named nested blueprints that doesn't feel super clunky. I figured I'd check with you before diving in, in case you've already started on something similar.

@demipixel
Copy link
Owner

Feel free to submit some PRs! I'm not actively doing any development on this project, so you don't have to worry about any conflicts. Mostly just doing upkeep and reviewing PRs.

As for blueprint books, I'm assuming it's clunky because blueprint books are just an array of blueprints as of right now? If so, you might just need to make a new BlueprintBook class.

@kellbot
Copy link
Contributor Author

kellbot commented Jul 2, 2023

ok cool, will do! I was thinking BlueprintBook probably needed a proper class, but didn't want to re-do any work you'd already done. I'll also clean up some of the features on my working branch and submit them as PRs once I write some tests for them.

@kellbot
Copy link
Contributor Author

kellbot commented Jul 3, 2023

I stubbed out a Book class and updated the rest of the library so tests are passing, but I suspect I may have broken some things there isn't test coverage for. I'll see if I can grab some projects which use factorio-blueprint to test with the book branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants