Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FeatureRequest] Let us choose Dark/Light themes manually #91

Open
JFMugen opened this issue Aug 13, 2023 · 9 comments
Open

[FeatureRequest] Let us choose Dark/Light themes manually #91

JFMugen opened this issue Aug 13, 2023 · 9 comments
Assignees
Labels
enhancement New feature or request

Comments

@JFMugen
Copy link

JFMugen commented Aug 13, 2023

I am assuming "Dynamic Color" setting changes Dark/Light mode but in my case there is no Dark theme of the phone (Huawei P9 Lite - Android 8) so it is always Light theme.

Letting us choose Dark/Light theme options can fix this issue.

@deltazefiro deltazefiro added the enhancement New feature or request label Aug 15, 2023
@LLinlll
Copy link

LLinlll commented Oct 22, 2023

@deltazefiro Hi,is this issue still available?Can I take this?Please assign to me.

@deltazefiro
Copy link
Owner

@LLinlll 👏

Hi,is this issue still available?Can I take this?Please assign to me.

Certainly! Thanks for your interest!
Feel free to open a PR once you are done!

@LLinlll
Copy link

LLinlll commented Oct 26, 2023

@deltazefiro I would like to ask if I can add a button to change the theme directly on the main page, or would you prefer it to be on the setting page? Although I'd prefer to be on the main page, the setting page seems too crowded.

@JFMugen
Copy link
Author

JFMugen commented Oct 26, 2023

@deltazefiro I would like to ask if I can add a button to change the theme directly on the main page, or would you prefer it to be on the setting page? Although I'd prefer to be on the main page, the setting page seems too crowded.

I think it would make sense to put it just below "Dynamic Color" setting.

@LLinlll
Copy link

LLinlll commented Oct 26, 2023

@deltazefiro I would like to ask if I can add a button to change the theme directly on the main page, or would you prefer it to be on the setting page? Although I'd prefer to be on the main page, the setting page seems too crowded.

I think it would make sense to put it just below "Dynamic Color" setting.

Sorry,I did not find where is the"Dynamic Color" setting.

@JFMugen
Copy link
Author

JFMugen commented Oct 26, 2023

Sorry,I did not find where is the"Dynamic Color" setting.

It's part of "Misc" settings.

@deltazefiro
Copy link
Owner

deltazefiro commented Oct 26, 2023

I would like to ask if I can add a button to change the theme directly on the main page, or would you prefer it to be on the setting page?

I'd suggest placing it beneath the "Dynamic Color" option in the setting page.
Android 10 introduced a global dark theme switch. Since over 70% of Android users have Android 10 or newer, switching themes isn't frequent enough to warrant a spot on the main page.

the setting page seems too crowded.

Absolutely! I'm planning a refactor to divide the settings across multiple pages and use data binding for enhanced maintainability. Perhaps in v0.10.

@SagXD
Copy link

SagXD commented Feb 2, 2024

Any Update on this? Also one more suggestion add a Pure Black Theme for Amoled Device User which can save some battery. Thanks

@SagXD
Copy link

SagXD commented Feb 3, 2024

@LLinlll Hey , Are you working on this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Todo
Development

No branches or pull requests

4 participants