Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Quick panel concerns #51

Open
ae5960e8-a6fc-491f-b252-898ecf59af95 opened this issue Feb 24, 2023 · 5 comments
Open

[Enhancement] Quick panel concerns #51

ae5960e8-a6fc-491f-b252-898ecf59af95 opened this issue Feb 24, 2023 · 5 comments
Labels
enhancement New feature or request

Comments

@ae5960e8-a6fc-491f-b252-898ecf59af95
Copy link

The quick panel feature which let's us enable and disable privacy is very useful but I see some problems with it. It is (1)accessable from the lock screen which is not ideal because anyone who finds the device will know Amarok is installed. (2)They can also toggle privacy from the lock screen.

  1. I suggest renaming the quick panel toggle to something generic like "Display mode". Active means privacy is disabled and Inactive means privacy is enabled. This means Amarok will be hard to detect.

  2. I also suggest making the quick panel toggle require the device to be unlocked so it can't be toggled from the lock screen. This means privacy cannot be disabled by someone else from the lock screen.

@deltazefiro deltazefiro added the enhancement New feature or request label Feb 24, 2023
@deltazefiro
Copy link
Owner

deltazefiro commented Feb 26, 2023

I also suggest making the quick panel toggle require the device to be unlocked so it can't be toggled from the lock screen. This means privacy cannot be disabled by someone else from the lock screen.

Fixed.

I suggest renaming the quick panel toggle to something generic like "Display mode". Active means privacy is disabled and Inactive means privacy is enabled. This means Amarok will be hard to detect.

I may implement it in the next major version, if possible.

Thanks.

@HarriBuh
Copy link

HarriBuh commented Apr 30, 2023

Another major issue here is that I can unlock Amarok via Quick panel even with the latest lock feature enabled.
I enabled both password and biometric lock and while I now have to unlock the app whenever I open the app from the app list, I am able to easily un- and relock the app from the Quick panel without any security measures!

@deltazefiro
Copy link
Owner

deltazefiro commented Apr 30, 2023

@HarriBuh Known bug 😉 WIP

@deltazefiro
Copy link
Owner

@HarriBuh

Another major issue here is that I can unlock Amarok via Quick panel even with the latest lock feature enabled.

Done. See the CI-built version.

@HarriBuh
Copy link

HarriBuh commented Jul 6, 2023

Great to hear! Looking forward to the official release then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Status: Todo
Development

No branches or pull requests

3 participants