Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add UNSET TBLPROPERTIES #2073

Open
ion-elgreco opened this issue Jan 13, 2024 · 6 comments · May be fixed by #2075
Open

Add UNSET TBLPROPERTIES #2073

ion-elgreco opened this issue Jan 13, 2024 · 6 comments · May be fixed by #2075
Assignees
Labels
enhancement New feature or request

Comments

@ion-elgreco
Copy link
Collaborator

No description provided.

@ion-elgreco ion-elgreco added the enhancement New feature or request label Jan 13, 2024
@ion-elgreco ion-elgreco self-assigned this Jan 13, 2024
@abhiaagarwal
Copy link

Will this be related to the "alter" namespace proposed in #1909? I need to implement a few of them for an application I'm developing

@ion-elgreco
Copy link
Collaborator Author

@abhiaagarwal yup, already have a PR open for this

@abhiaagarwal
Copy link

@ion-elgreco Yeah, I read through it, but it doesn't explicitly namespace everything to "alter", on either the Python or the Rust side. Is that still planned? I want to develop Alter Column, I want to know what's the preferred format for developing a something in `core/operations'

@ion-elgreco
Copy link
Collaborator Author

@abhiaagarwal in the PR you can see it's added as a method to the TableAlterer class. I suggest to go through the PR because it shows what you need to do to add an operation in rust, expose it to python and then add tests for it

@abhiaagarwal
Copy link

Sorry, I was unclear — I see that it does exist in Python, but will the idea of the "alter namespace" be exported to rust as well? I'm using delta-rs primarily in rust. I'm wondering how to group all Alter-related expressions together on the rust side to be exported into the alter namespace on the python, or to just handle it on the python side exclusively.

@ion-elgreco
Copy link
Collaborator Author

ion-elgreco commented Feb 2, 2024

You don't really need to group them in rust, the grouping is mainly done in python under TableAlterer, you just expose it operation as a method under RawDeltaTable

@abhiaagarwal feel free to ping me on slack if you want to discuss, I have the same username there

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants