Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metavault - issues #101

Closed
0xroll opened this issue May 5, 2024 · 5 comments
Closed

Metavault - issues #101

0xroll opened this issue May 5, 2024 · 5 comments

Comments

@0xroll
Copy link
Contributor

0xroll commented May 5, 2024

https://github.com/delta-hq/l2-lxp-liquidity-reward/pull/26/files#diff-16d341d6772401e45c3c87cbe24250b2fba9774b6010d5b3b074a686c40cb23aR35-R44

  1. v3 positions should only consider active position only (in range)
  2. token balance should be in raw amount (BIGINT) , currently its in real amount
  3. you need to sum up the balances of the same asset before pushing to the output (sum both v3 + perps)

can you link the gh repo for the v3 + trades

@0xroll
Copy link
Contributor Author

0xroll commented May 5, 2024

@sdcrypt0 hi please check the above, and provide gh repo link for subgraph

@sdcrypt0
Copy link
Contributor

sdcrypt0 commented May 6, 2024

Hi @0xroll ,
We fixed issues and open a pull request. Please check.
Do you need subgraph repositories or smart contract repositories?

@0xroll
Copy link
Contributor Author

0xroll commented May 7, 2024

Hi @0xroll , We fixed issues and open a pull request. Please check. Do you need subgraph repositories or smart contract repositories?

the subgraph repo

@sdcrypt0
Copy link
Contributor

sdcrypt0 commented May 7, 2024

@0xroll i have added you to the repo. please refer here: https://github.com/metavaultorg/dex-subgraphs

@sdcrypt0
Copy link
Contributor

@0xroll
new pull request created for new requirements.
#143

@0xroll 0xroll closed this as completed May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants