Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent merge type comment #16

Open
jerome-white opened this issue Apr 25, 2024 · 1 comment
Open

Inconsistent merge type comment #16

jerome-white opened this issue Apr 25, 2024 · 1 comment

Comments

@jerome-white
Copy link

In aggregate_rows the comment and the code do not match:

## Just use the merge function with merge type 1:m
df_lm_matched = merge(df, ref_df, merge_type="1:1", on=None, model=model, left_on=left_on,

Is this intentional?

@econabhishek
Copy link
Collaborator

Hi Jerome, thanks for pointing it out. We deprecated merge type (#14), I guess this is a legacy artifact. Happy to remove this in the next version. I would just ignore it for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants