Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecated classes/methods and non-compiling examples in README.md #201

Open
bakoontz opened this issue Nov 18, 2020 · 1 comment
Open

Comments

@bakoontz
Copy link

bakoontz commented Nov 18, 2020

There are a number of deprecated warnings when using the examples in the README. For instance, RuleBook<Integer> is deprecated, as it getIntVal() and getDblVal(). Is there an updated set of examples somewhere, or should I simply ignore these warnings?

Also, code based on this example doesn't compile due to type incompatibilities:

public class ExampleSolution {
  public static void main(String[] args) {
    RuleBook homeLoanRateRuleBook = RuleBookBuilder.create(HomeLoanRateRuleBook.class).withResultType(Double.class)
      .withDefaultResult(4.5)
      .build();
@bakoontz
Copy link
Author

bakoontz commented Nov 18, 2020

It appears the compilation error has something to do with two RuleBook definitions in two different packages:

import com.deliveredtechnologies.rulebook.model.RuleBook;
import com.deliveredtechnologies.rulebook.RuleBook;

Please consider clarifying this in the docs, or do it the right way and give the interface a slightly different name. Or maybe even remove the deprecated RuleBook implementation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant