Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Email and Profile Info Scope #48

Open
wanderer056 opened this issue Feb 9, 2024 · 3 comments
Open

Add Email and Profile Info Scope #48

wanderer056 opened this issue Feb 9, 2024 · 3 comments
Labels
enhancement New feature or request

Comments

@wanderer056
Copy link

wanderer056 commented Feb 9, 2024

Currently, the plugin doesn't have a way to request for email and profile info while SignIn. Add a flag that can be configured in game.project for email and ProfileInfo.
The game.project configuration will look like:

[gpgs]
app_id = 29489714610
use_saved_games = 1
request_server_auth_code = 0
request_id_token = 1
client_id = somestring.google.com
request_email = 1
request_profile_info = 1

Add functions for email and profile info:

gpgs.get_email()
gpgs.get_profile()
@britzl
Copy link
Contributor

britzl commented Feb 11, 2024

Function to get email: https://developers.google.com/android/reference/com/google/android/gms/auth/api/signin/GoogleSignInAccount#getEmail()

@wanderer056 which function would gpgs.get_profile() correspond to?

@britzl britzl added the enhancement New feature or request label Feb 11, 2024
@wanderer056
Copy link
Author

wanderer056 commented Feb 11, 2024

builder.requestProfile() adds displayName,givenName,familyName,Id,photoUrl along with email.
https://developers.google.com/identity/sign-in/android/people
I was thinking that these could be combined and returned as a json string when gpgs.get_profile() is called. Or should it be made individual functions? @britzl
Below is the draft PR i am working on.

@wanderer056
Copy link
Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants