Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

flag to configure time stamps in Pepr #795

Closed
cmwylie19 opened this issue May 10, 2024 · 1 comment · Fixed by #801
Closed

flag to configure time stamps in Pepr #795

cmwylie19 opened this issue May 10, 2024 · 1 comment · Fixed by #801
Labels
enhancement New feature or request

Comments

@cmwylie19
Copy link
Collaborator

Is your feature request related to a problem? Please describe.

When debugging across kube-apiserver logs, cluster audit logs, and Pepr logs the Pepr logs use a timestamp and we have to convert them to UTC. We want this to be configurable.

Describe the solution you'd like

  • Given I want the Pepr logs to be in UTC format
  • When I configure the controller
  • Then the logs are printed in the UTC format

Describe alternatives you've considered

(optional) A clear and concise description of any alternative solutions or features you've considered.

Additional context

Add any other context or screenshots about the feature request here.
@cmwylie19 cmwylie19 added the enhancement New feature or request label May 10, 2024
@btlghrants
Copy link
Collaborator

It looks like this should just involve adding a bit of config to Pino -- and, of course, then figuring out which test break:

Config docs:

Config option "timestamp" can take a function arg:

Which looks like it can take a "pino.stdTimeFunctions.isoTime" arg that'll do what we want..?

@cmwylie19 cmwylie19 mentioned this issue May 15, 2024
Merged
5 tasks
cmwylie19 added a commit that referenced this issue May 17, 2024
@cmwylie19
feat: pino log timestamp config (#801)
82ed82e 
## Description

Configuration options for pino timestamps. Includes docs, same defaults
but with the option to override to iso time.

## Related Issue

Fixes #795 
<!-- or -->
Relates to #

## Type of change

- [ ] Bug fix (non-breaking change which fixes an issue)
- [x] New feature (non-breaking change which adds functionality)
- [ ] Other (security config, docs update, etc)

## Checklist before merging

- [x] Test, docs, adr added or updated as needed
- [x] [Contributor Guide
Steps](https://docs.pepr.dev/main/contribute/contributor-guide/#submitting-a-pull-request)
followed

---------

Signed-off-by: Case Wylie <cmwylie19@defenseunicorns.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
Pepr Project Board
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: pino log timestamp config defenseunicorns/pepr
2 participants
@cmwylie19 @btlghrants