Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

named callbacks ADR #675

Open
cmwylie19 opened this issue Mar 21, 2024 · 0 comments · May be fixed by #676
Open

named callbacks ADR #675

cmwylie19 opened this issue Mar 21, 2024 · 0 comments · May be fixed by #676
Assignees
Labels
enhancement New feature or request

Comments

@cmwylie19
Copy link
Collaborator

Is your feature request related to a problem? Please describe.

you have a system of callbacks that produce logs. The callbacks are anonymous, so debugging which log comes from which callback can be confusing unless you manually write a name in the log message from within the callback. This consideration needs an ADR

Describe the solution you'd like

  • Given we want to look why we decided or decided not to create named callbacks
  • When we look in the adrs
  • Then we find the reason

Describe alternatives you've considered

(optional) A clear and concise description of any alternative solutions or features you've considered.

Additional context

Add any other context or screenshots about the feature request here.

@cmwylie19 cmwylie19 added the enhancement New feature or request label Mar 21, 2024
@cmwylie19 cmwylie19 self-assigned this Mar 21, 2024
@cmwylie19 cmwylie19 changed the title named callbacks named callbacks ADR Mar 21, 2024
@cmwylie19 cmwylie19 linked a pull request Mar 21, 2024 that will close this issue
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: 👀 In review
Development

Successfully merging a pull request may close this issue.

1 participant