Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dpa2 model may need a fake communication op to deal with nloc == 0. #3732

Open
github-actions bot opened this issue Apr 30, 2024 · 0 comments
Open

dpa2 model may need a fake communication op to deal with nloc == 0. #3732

github-actions bot opened this issue Apr 30, 2024 · 0 comments

Comments

@github-actions
Copy link

this should be fixed after wrapping comm op as a pure c++ implementation.

Line: 135

nghost, ntypes, 1, daparam, nall, aparam_nall);
int nloc = nall_real - nghost_real;
int nframes = 1;
// TODO: dpa2 model may need a fake communication op to deal with nloc == 0.
// this should be fixed after wrapping comm op as a pure c++ implementation.
if (nloc == 0) {
// no backward map needed
ener.resize(nframes);
// dforce of size nall * 3
force.resize(static_cast<size_t>(nframes) * fwd_map.size() * 3);
fill(force.begin(), force.end(), (VALUETYPE)0.0);

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant