Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace string search with API call in freeze function #3713

Open
coderabbitai bot opened this issue Apr 26, 2024 · 0 comments
Open

Replace string search with API call in freeze function #3713

coderabbitai bot opened this issue Apr 26, 2024 · 0 comments
Assignees
Milestone

Comments

@coderabbitai
Copy link

coderabbitai bot commented Apr 26, 2024

In the function of , the model type is currently determined by searching for a string in . This method is not robust and could lead to errors if the string format changes. It is suggested to replace this string search with a dedicated API call that can more reliably determine the model type.

Affected code:

if '"type": "dpa2"' in model.model_def_script:

This issue was identified in PR #3657 and discussed in the comments: #3657 (comment)

@njzjz njzjz added this to the v3.0.0 milestone Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants