Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(excluded_types != [] and attn_layer > 0) need fix #3707

Closed
github-actions bot opened this issue Apr 24, 2024 · 1 comment · Fixed by #3815
Closed

(excluded_types != [] and attn_layer > 0) need fix #3707

github-actions bot opened this issue Apr 24, 2024 · 1 comment · Fixed by #3815
Assignees
@iProzd
Labels
branch: devel todo comment type: todo

Comments

@github-actions
Copy link

Line: 177

deepmd-kit//source/tests/consistent/descriptor/test_dpa1.py

Lines 174 to 184 in d0cd9f3

concat_output_tebd,
precision,
) = self.param
# TODO (excluded_types != [] and attn_layer > 0) need fix
return (
env_protection != 0.0
or smooth_type_embedding
or not normalize
or temperature != 1.0
or (excluded_types != [] and attn_layer > 0)
)

@iProzd iProzd self-assigned this May 1, 2024
@iProzd iProzd mentioned this issue May 23, 2024
Merged
@iProzd iProzd linked a pull request May 23, 2024 that will close this issue
fix: DPA1 should use masked gate when excluded_types #3815
Merged
github-merge-queue bot pushed a commit that referenced this issue May 24, 2024
@iProzd
fix: DPA1 should use masked gate when excluded_types (#3815)
8cd3cba 
Fix #3707.
@github-actions GitHub Actions
Copy link
Author

Closed in commit 8cd3cba

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@iProzd iProzd

Labels
branch: devel todo comment type: todo
Projects
DeePMD-3.0.0 beta release
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: DPA1 should use masked gate when excluded_types iProzd/deepmd-kit
1 participant
@iProzd