Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace GlobalC in module_gint #4164

Merged
merged 18 commits into from
May 21, 2024
Merged

Replace GlobalC in module_gint #4164

merged 18 commits into from
May 21, 2024

Conversation

A-006
Copy link
Collaborator

@A-006 A-006 commented May 13, 2024

Reminder

  • Have you linked an issue with this pull request?
  • Have you added adequate unit tests and/or case tests for your pull request?
  • Have you noticed possible changes of behavior below or in the linked issue?
  • Have you explained the changes of codes in core modules of ESolver, HSolver, ElecState, Hamilt, Operator or Psi? (ignore if not applicable)

Linked Issue

close #4163

Unit Tests and/or Case Tests for my changes

  • A unit test is added for each new feature or bug fix.

What's changed?

  • I implement the replacement of GlobalC in module_gint using function parameter passing

Any changes of core modules? (ignore if not applicable)

-The separation of module_gint into its own module is now one step closer

@mohanchen mohanchen added the The Absolute Zero Reduce the "entropy" of the code to 0 label May 13, 2024
@mohanchen mohanchen merged commit c6f8609 into deepmodeling:develop May 21, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mohanchen mohanchen mohanchen approved these changes

Assignees
No one assigned
Labels
The Absolute Zero Reduce the "entropy" of the code to 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove GlobaC in module_gint
2 participants
@A-006 @mohanchen