Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A same deepks example can converge in the old version, but not in the new version #4156

Closed
16 tasks
xuan112358 opened this issue May 12, 2024 · 5 comments
Closed
16 tasks
Assignees
Labels
Performance Issues related to fail running ABACUS

Comments

@xuan112358
Copy link

Describe the bug

I tried to use a deepks model to perform SCF calculation in a periodic system containing 32 water molecules in a unit cell.
When I used the older version of ABACUS, v3.1.2, it can converge normally.
image

But when I tried the newer version, 3.6.1, the DRHO would oscillate, and SCF could not converge.
image

I know the mixing method is different between these two versions. So I changed the method from "pulay" in v3.1.2 to "brodyen" in v3.6.2. Should I change other INPUT parameters to get converged results?
By the way, I have tested to use PBE in v3.6.2, and it can converge normally too.

Expected behavior

No response

To Reproduce

Inputs and results by v3.1.2 / v3.6.1 are in directory 01_3.1.2 / 02_3.6.2
github_files.zip
.

Environment

I use mpiicpc and icpc to compile.

Additional Context

No response

Task list for Issue attackers (only for developers)

  • Verify the issue is not a duplicate.
  • Describe the bug.
  • Steps to reproduce.
  • Expected behavior.
  • Error message.
  • Environment details.
  • Additional context.
  • Assign a priority level (low, medium, high, urgent).
  • Assign the issue to a team member.
  • Label the issue with relevant tags.
  • Identify possible related issues.
  • Create a unit test or automated test to reproduce the bug (if applicable).
  • Fix the bug.
  • Test the fix.
  • Update documentation (if necessary).
  • Close the issue and inform the reporter (if applicable).
@WHUweiqingzhou WHUweiqingzhou self-assigned this May 13, 2024
@WHUweiqingzhou
Copy link
Collaborator

@xuan112358,
I'd like to ask which version of ABACUS's data was used to train the DEEPKS model here? I suspect it's due to version 3.4.0, where we modified the two-center integrals @jinzx10, causing inconsistencies in the dataset precision and leading to a lack of convergence.
@dyzheng, what is your opinion?

@WHUweiqingzhou WHUweiqingzhou added the Performance Issues related to fail running ABACUS label May 13, 2024
@xuan112358
Copy link
Author

@WHUweiqingzhou I used the data generated by ABACUS v3.1.2. Would this caused the problem?

@WHUweiqingzhou
Copy link
Collaborator

@xuan112358
Yes, I think that's one of the reasons. @dyzheng @wenfei-li @ouqi0711 what is your suggestion?

@ouqi0711
Copy link
Collaborator

I think the modification to the two-center integrals should be the reason that causing the convergence failure. We have investigated similar problem of the perovskite system. The short answer is that data/model trained via v3.4 or earlier can not be directly applied to the current version.

@xuan112358
Copy link
Author

OK,I think I understand.
I also tried to compile ABACUS v3.6.2 without the new two-center integral code, by turning off the compilation option USE_NEW_TWO_CENTER. And I found that this time the result was consistent with the older version. I think it does suggest that it's the new two-center integrals that caused the different results.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Performance Issues related to fail running ABACUS
Projects
None yet
Development

No branches or pull requests

3 participants