Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] NLP property - sudden stop #2722

Open
Nadav-Barak opened this issue Jan 14, 2024 · 2 comments
Open

[FEAT] NLP property - sudden stop #2722

Nadav-Barak opened this issue Jan 14, 2024 · 2 comments
Labels
feature Feature update or code change to the package linear needs triage Issue needs to be labeled and prioritized

Comments

@Nadav-Barak
Copy link
Collaborator

We want to add an additional property of sudden stop, meaning a binary classifier that detects whether or not generated text was stoped mid-sentence. for example:

The Joachimsthaler of the Kingdom of Bohemia was

The property must work well on english text.
When adding the property:

  1. it should be added in code to deepchecks/nlp/utils/text_properties.py
  2. it should be incorporated in the calculate_builtin_properties function
  3. Test for the property should by added to tests/nlp/utils/test_properties.py
  4. Documentation for the property should be added to docs/source/nlp/usage_guides/nlp_properties.rst
@Nadav-Barak Nadav-Barak added the feature Feature update or code change to the package label Jan 14, 2024
@github-actions github-actions bot added needs triage Issue needs to be labeled and prioritized linear labels Jan 14, 2024
@Nadav-Barak
Copy link
Collaborator Author

@Ragh

@mobley-trent
Copy link

I'd like to work on this feature @Nadav-Barak

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Feature update or code change to the package linear needs triage Issue needs to be labeled and prioritized
Projects
None yet
Development

No branches or pull requests

2 participants