Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG][Tabular] bad validation on model classes #2495

Open
Nadav-Barak opened this issue May 4, 2023 · 0 comments
Open

[BUG][Tabular] bad validation on model classes #2495

Nadav-Barak opened this issue May 4, 2023 · 0 comments
Assignees
Labels
bug linear tabular Affects deepchecks.tabular package

Comments

@Nadav-Barak
Copy link
Collaborator

We should validate the the model classes contain all observed labels + is of the same length of the proba

Currently it is done partially and spraded in different places in the package.

Suggestion:

In context add functions of get_predictions() and get_probabilities() and use them instead of calling the context.model.predict_proba functionality. Validation should be done on the first time those functions are called

@Nadav-Barak Nadav-Barak added the bug label May 4, 2023
@Nadav-Barak Nadav-Barak self-assigned this May 4, 2023
@github-actions github-actions bot added needs triage Issue needs to be labeled and prioritized linear labels May 4, 2023
@Nadav-Barak Nadav-Barak added tabular Affects deepchecks.tabular package and removed needs triage Issue needs to be labeled and prioritized labels May 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug linear tabular Affects deepchecks.tabular package
Projects
None yet
Development

No branches or pull requests

1 participant