Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Two definitions in the base_influence.py #21

Open
lucashervier opened this issue Jan 11, 2023 · 0 comments
Open

[Bug]: Two definitions in the base_influence.py #21

lucashervier opened this issue Jan 11, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@lucashervier
Copy link
Collaborator

Module

Common

Contact Details

lucas.hervier@irt-saintexupery.com

Current Behavior

If we take a close look on the class BaseInfluenceCalculator we can see that the method _estimate_individual_influence_values_from_batch is defined two times. Once as an @abstractmethod and the other time explicitly.

Expected Behavior

To have a single definition for the method _estimate_individual_influence_values_from_batch for the class BaseInfluenceCalculator

Version

v0.1.0

Environment

- OS:
- Python version:
- Tensorflow version:
- Packages used version:

Relevant log output

No response

To Reproduce

N/A
@lucashervier lucashervier added the bug Something isn't working label Jan 11, 2023
@Agustin-Picard Agustin-Picard mentioned this issue Feb 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lucashervier