Makes max_calls for BranchBound predicate search configurable for training call #1157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@fgregg Sorry to ping you directly, but I am seeing really interesting behavior now that I added this configurable For the exact same data, labels, and np/python seeds, I will get the "no predicates found" error at different For the case I am looking at:
Any thoughts on why this could be? Maybe the optimizer happens to land on a valid value in those ranges? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR codifies @fgregg 's suggestion here to increase value for
max_callsby making that value configurable from the API. Not sure if this change should be included in prod but it does enable my application to work as intended.Resolves #1156