Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused sample_size and blocked_proportion from public API #1054

Open
NickCrews opened this issue Jun 9, 2022 · 0 comments
Open

Remove unused sample_size and blocked_proportion from public API #1054

NickCrews opened this issue Jun 9, 2022 · 0 comments

Comments

@NickCrews
Copy link
Contributor

NickCrews commented Jun 9, 2022 •
edited

See cc609bb

There I already removed the internals that make it look like we actually use these params. Now we just need to decide what to do. Add a warning that these params aren't used, and in a later release actually remove them from the public API?

@fgregg
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@NickCrews