Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skip_training configuration value overwritten #46

Open
DaveKlassen opened this issue Mar 31, 2016 · 1 comment
Open

skip_training configuration value overwritten #46

DaveKlassen opened this issue Mar 31, 2016 · 1 comment

Comments

@DaveKlassen
Copy link
Contributor

I was setting a value for skip_training in the configuration file, however this value is always overridden by the command line settings. The command lines settings are loaded onto the pre-loaded configuration file settings, and whenever this happens skip_training is always set to false, even when the command-line flag is not supplied to the command/invocation.

@DaveKlassen
Copy link
Contributor Author

I looked at altering the code to prevent the command line option overwrite, from erasing the configuration file specification (for skip_training), but the code was too simple for me to want to rip it apart and expose the key being over written (due the default action taken).

For the sake of reducing code bloat, perhaps the documentation file should state if you wish to skip_training, do so by explicitly specifying the command line option --skip_training, as opposed to placing it in a configuration file.

FWIK: Typical command line syntax allows environment variables to persist, but also allows a configuration file to override the values, and similarly command line options override the other two. However if a command line option isn't specified, it should not overwrite either configuration file or environment variable alterations. In any regard now that I have found a solution, I am content.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant