Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calculation of block size uses wrong block-time #2403

Open
ineiti opened this issue Nov 12, 2020 · 0 comments
Open

Calculation of block size uses wrong block-time #2403

ineiti opened this issue Nov 12, 2020 · 0 comments
Labels
Projects

Comments

@ineiti
Copy link
Member

ineiti commented Nov 12, 2020

When collecting ClientTransactions the routine makes sure that the block doesn't get too big. For this to work it applies one ClientTransction after another to the current. However, two things are not done properly:

  1. Every ClientTransaction is applied to a clean state, not taking into account eventually queued up ClientTransactions
  2. It uses the wrong timestamp for the block, now, where it should be the time set by the leader later

This means that the size of the final block might be off:

  1. a ClientTransaction that depends on another ClientTransaction in the same block might produce fewer or more StateChanges
  2. a ClientTransaction that creates a different set of StateChanges depending on the time will produce fewer or more StateChanges

Anyway, the attack surface is deemed very little, but it's still written down here...

@ineiti ineiti added the bug label Nov 12, 2020
@ineiti ineiti added this to TODO in Cothority via automation Nov 12, 2020
@ineiti ineiti moved this from TODO to Closed in Cothority Nov 12, 2020
@ineiti ineiti moved this from Closed to BUG in Cothority Nov 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Cothority
  
BUG
Development

No branches or pull requests

1 participant