Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trezor: Webpack build broken on master. #3920

Closed
JoeGruffins opened this issue Oct 18, 2023 · 1 comment · Fixed by #3922
Closed

Trezor: Webpack build broken on master. #3920

JoeGruffins opened this issue Oct 18, 2023 · 1 comment · Fixed by #3922

Comments

@JoeGruffins
Copy link
Member

master is currently 391d8a5

A minor trezor-connect version bump moved a file that was needed by Trezor. @matheusd figured this out and here is the diff to make current master move the correct files, also from @matheusd :

diff --git a/webpack/trezor.js b/webpack/trezor.js
index 3fa4713f5..fe0545e28 100644
--- a/webpack/trezor.js
+++ b/webpack/trezor.js
@@ -53,7 +53,8 @@ module.exports = {
 
         new CopyWebpackPlugin({
             patterns: [
-                { from: "./node_modules/trezor-connect/data", to: "data" }
+                { from: "./node_modules/trezor-connect/data", to: "data" },
+                { from: "./node_modules/@trezor/transport/messages.json", to: "data/messages" }
             ]
         }),

Staying on version 8 will however show this warning:

index.js:172 trezor-connect version 8 has been deprecated. Please start using @trezor/connect version 9 https://www.npmjs.com/package/@trezor/connect

#3911 also closes this issue by bumping the version and placing the correct files in the correct place, albeit without webpack at the moment.

@matheusd
Copy link
Member

I think we should go with the immediate fix right now, so that any new versions released support trezor again, then we can work on the proper v9 webpack magic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants