Skip to content
This repository has been archived by the owner on Dec 18, 2018. It is now read-only.

RtRepositories.java:46-48: Modify repository(repositoryKey)... #114

Open
0pdd opened this issue Jun 9, 2017 · 5 comments
Open

RtRepositories.java:46-48: Modify repository(repositoryKey)... #114

0pdd opened this issue Jun 9, 2017 · 5 comments

Comments

@0pdd
Copy link

0pdd commented Jun 9, 2017

The puzzle 112-09216f58 in src/main/java/com/amihaiemil/versioneye/RtRepositories.java (lines 46-48) has to be resolved: "Modify repository(repositoryKey) method to return a DetailedRepository as json returned is incompatible with Repository one."

The puzzle was created by sherif on 08-Jun-17.

Estimate: 30 minutes, role: DEV.

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.

@0pdd
Copy link
Author

0pdd commented Jun 9, 2017

@amihaiemil please pay attention to this new issue.

@SherifWaly
Copy link
Contributor

@amihaiemil
For this one I found that the Repository attributes can be found if we used json.getString("repo") so we will need jsons for Repository or other solution is to make another repository that have more details, what do you think about it?

@amihaiemil
Copy link
Member

amihaiemil commented Jun 12, 2017

@SherifWaly We can have:

public interface DetailedRepository extends Repository {
    //methods for new attributes
}

It has to still be a Repository so the client can work with both of them where he expects a Repository.
They will probably have a method expecting Repository, and instead of calling the pagination to get one, they might wanna find it by name :)

@amihaiemil
Copy link
Member

@SherifWaly but don't do it yet (low on budget these days). I'll let you know as soon as possible when we get back on track; hope it won't take long :)

@SherifWaly
Copy link
Contributor

@amihaiemil Ok, no problem :D

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants