Comment in a Stream of Mapping

[ANadrowski]

Hi,

Is the following Yaml valid?

---
  # Comment
  name: "eo-yaml"
  version: 4.3.5

When I write it:

YamlNode node = Yaml.createYamlMappingBuilder()
            .add("name", "eo-yaml")
            .add("version", "4.3.5")
            .build("Comment");
        YamlStream expected = Yaml.createYamlStreamBuilder()
            .add(node)
            .build();
System.out.println(expected);

The comment does not appear:

---
  name: "eo-yaml"
  version: 4.3.5

Am I writing this Yaml wrong or maybe it is a little bug?

Thanks.

[amihaiemil]

@ANadrowski it is a bug, yes. I remember comments on streams were not 100% implemented :D

[ANadrowski]

@amihaiemil Could you assign it to me?

[amihaiemil]

@ANadrowski This might be a bit difficult, don't spend too much time on it. Better spend some time to understand how comments are read in sequences and mapping, then we'll continue in another ticket.

[ANadrowski]

@amihaiemil Good. I will take a look on it in the next week :)

[ANadrowski]

@amihaiemil as you said the solution is a bit difficult, but I believe that a good start is to implement the method:

 @Override
    public Comment comment() {

inside of the class ReadYamlStream.java, right?

[amihaiemil]

@ANadrowski yes, I think YamlStream already has that method on the interface, but it has a default implementation which returns null, if I remember well :D

[amihaiemil]

@ANadrowski you can leave this task, if you want, and look for bounties in self-xdsd.

[ANadrowski]

@amihaiemil it is ok, I will leave this issue, please unassign it to me. Thanks.