Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Message attachments should be saved #1377

Open
paksa92 opened this issue Apr 21, 2024 · 2 comments
Open

Message attachments should be saved #1377

paksa92 opened this issue Apr 21, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@paksa92
Copy link

paksa92 commented Apr 21, 2024

Is your feature request related to a problem? Please describe.
Message attachments are currently not saved, as it's missing in the Message entity and typeorm migrations in the data-store package.

Describe the solution you'd like
I want message attachments to be saved in the agent's data store.

Additional context
I'm working on a PR that adds this, but I'm wondering if there's a reason why this is missing?

@paksa92 paksa92 added the enhancement New feature or request label Apr 21, 2024
@mirceanis
Copy link
Member

It isn't intentionally omitted. A pr would be welcome.

Messages are also saved in raw, which should mean "as they are received". I believe attachments should still be there in the raw message.

@paksa92
Copy link
Author

paksa92 commented Apr 21, 2024

Yes, they are in indeed there in the raw message.

Tests are failing in the next branch it seems. Will look into it in the coming days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants