Skip to content
This repository has been archived by the owner on Feb 17, 2021. It is now read-only.

Not usable on Node.js 12 #23

Open
filips123 opened this issue Jun 2, 2019 · 9 comments
Open

Not usable on Node.js 12 #23

filips123 opened this issue Jun 2, 2019 · 9 comments
Labels
bug Something isn't working element-lib Element Protocol Library

Comments

@filips123
Copy link

Truffle and its sub-packages (truffle-contract) are unusable on Node.js 12 (trufflesuite/truffle#2070). Because of that, this package is also unusable on Node.js 12.

@OR13
Copy link
Collaborator

OR13 commented Jun 3, 2019

@filips123 thanks for opening this! As you noted, we'll need to keep an eye on truffle and upgrade once they add support.

@OR13 OR13 added the enhancement New feature or request label Jul 4, 2019
@OR13
Copy link
Collaborator

OR13 commented Jul 26, 2019

Bumping this issue to a bug, we really would love to use node 12... especially because it is a requirement for https://github.com/panva/jose

@OR13 OR13 added bug Something isn't working element-lib Element Protocol Library and removed enhancement New feature or request labels Jul 26, 2019
@filips123
Copy link
Author

@OR13 This will probably be fixed in next version of Web3.

@mkhraisha
Copy link

This has been fixed on truffle/web3 web3/web3.js#2913

@gjgd
Copy link
Member

gjgd commented Nov 14, 2019

Looks like this is still blocked because of another dependency of @truffle/hdwallet-provider

See: trufflesuite/truffle#2070 (comment)

ethereumjs/ethereumjs-wallet#91

@OR13
Copy link
Collaborator

OR13 commented Nov 15, 2019

sadness... thanks for pinging those issues.

@gjgd
Copy link
Member

gjgd commented Nov 15, 2019

Most features seem to be working in node 12 but a couple of tests are failing, mmmh. Looks like it's related to the truffle wallet

https://travis-ci.org/decentralized-identity/element/builds/612247263

@coder5876
Copy link

I'm still having trouble with this issue:

error @transmute/element-lib@0.4.3: The engine "node" is incompatible with this module. Expected version ">=10.0 <12.0". Got "12.14.1"

@gjgd gjgd mentioned this issue Jan 24, 2020
@gjgd
Copy link
Member

gjgd commented Jan 24, 2020

Hi @christianlundkvist , thanks for being vigilant about this issue!

As far as I can see, with the latest version of truffle (which was the last blocking dependency), Element now works with Node 12.

I've opened a PR to remove the <12 constraints in package.json. We'll let you know in this thread as soon as we ship the next version that contains this change.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working element-lib Element Protocol Library
Projects
None yet
Development

No branches or pull requests

5 participants