Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linting to help contribution #75

Open
leptest opened this issue May 4, 2018 · 2 comments
Open

Linting to help contribution #75

leptest opened this issue May 4, 2018 · 2 comments

Comments

@leptest
Copy link

leptest commented May 4, 2018

Suggestion:
Adopt popular community configs and common linting tasks.

Why:
To help others when contributing to and integrating this project.

How:
Use eslint, prettier, stylelint, and/or an editorconfig.
Most of these have a popular community config that could be adopted.

Info:
Related: #67 #68
Semi related: #71 #74 #73
(the semi related ones would have been caught/fixed by using a standard config)

You mentioned in #57 about certain things being removed when a developer forks the project, and i agree this would fall in that category. But i think they are important when contributing to this project.

What are your thoughts?

@ekoeryanto
Copy link
Contributor

One more reason, developer who knows more than 1 programing language or framework use IDE as a (super hero) helper of remembering the API. I do, the same, and I hate that when I see zigzag red lines below the texts when I am writing 🔢

@leptest
Copy link
Author

leptest commented May 8, 2018

We could also just use the same configs as https://github.com/netlify/netlify-cms or https://github.com/gatsbyjs/gatsby?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants