Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix identifier storage in Alignment class #289

Open
thomashopf opened this issue Mar 30, 2023 · 1 comment
Open

Fix identifier storage in Alignment class #289

thomashopf opened this issue Mar 30, 2023 · 1 comment
Assignees

Comments

@thomashopf
Copy link
Contributor

Currently memory usage is defined by longest identifier due to use of numpy for identifier storage, which can create a large overhead if one header is longer than others - but numpy functionality not that relevant on identifiers

Ideally, replace with pd.Series to keep slicing functionality while making use of better string memory management of pandas

@aaronkollasch

@thomashopf thomashopf self-assigned this Mar 30, 2023
@thomashopf
Copy link
Contributor Author

Also add an option to from_file method to split identifiers on first whitespace (off by default)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant