Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CouplingsScoresCompared_longrange.csv misses couplings #252

Open
ddingding opened this issue Oct 7, 2020 · 4 comments
Open

CouplingsScoresCompared_longrange.csv misses couplings #252

ddingding opened this issue Oct 7, 2020 · 4 comments

Comments

@ddingding
Copy link

Hi,

Just to mark that for the complex pipeline, the CouplingsScoresCompared_longrange.csv is missing some inter couplings in the complex when the couplings are close (for example a coupling A_i,i=60 with A_j,j=58 is missing in my protein complex but this coupling is indeed displayed on the contactmap).

Presumably the filter for longrange is not taking into account that the 2 positions i and j are coming from different proteins.

Cheers

@kpgbrock
Copy link
Contributor

kpgbrock commented Oct 7, 2020

Hi, which version of evcouplings did you use (or which environment on o2?) I saw this bug in a previous version, but I think it's been corrected in the latest - let me know and I'll follow up on if we need to update code/envs!

@ddingding
Copy link
Author

Hi,
Yeah I'm using the evcouplings_dev_test on o2.

These wrong short-range inters are also missing from the CouplingScoresCompared_all.csv file, but they are in the couplingsScoresCompared_inter file.

Cheers

@thomashopf
Copy link
Contributor

Looping in @aggreen

@aggreen
Copy link
Contributor

aggreen commented Oct 16, 2020

Strange yeah, I believe this is fixed in my new version and will check on it when I update that pull request

@aggreen aggreen mentioned this issue Oct 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants