Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Cell tag-based style UI #40

Draft
wants to merge 55 commits into
base: main
Choose a base branch
from
Draft

Add Cell tag-based style UI #40

wants to merge 55 commits into from

Conversation

bollwyvl
Copy link
Contributor

@bollwyvl bollwyvl commented Dec 22, 2022 •
edited

References

Changes

  • update env
  • fix broken CI badges
  • refactor non-structural, style-related aspects to design manager
  • add (multi) cell slide type commands
  • bump/test minimum python3.8, test on 3.11
  • refactor design tools as composable widget
    • move existing tools into new design tools
    • add cell tag tool
    • add style template tool
  • ???
  • tests
  • docs
  • changelog

@bollwyvl bollwyvl marked this pull request as draft December 22, 2022 15:39
@codecov
Copy link

codecov bot commented Dec 22, 2022 •
edited

Codecov Report

Merging #40 (4d54d13) into main (dc0abf2) will decrease coverage by 3.66%.
The diff coverage is 88.93%.

❗ Current head 4d54d13 differs from pull request most recent head fb4d878. Consider uploading reports for the commit fb4d878 to get more accurate results

@@            Coverage Diff             @@
##             main      #40      +/-   ##
==========================================
- Coverage   92.82%   89.16%   -3.66%     
==========================================
  Files          14       24      +10     
  Lines        1268     1514     +246     
  Branches      248      278      +30     
==========================================
+ Hits         1177     1350     +173     
- Misses         45      106      +61     
- Partials       46       58      +12
Flag Coverage Δ
back-end 100.00% <100.00%> (ø)
front-end 89.03% <88.83%> (-3.69%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
js/jupyterlab-deck/src/plugin.ts 100.00% <ø> (ø)
js/jupyterlab-deck/src/tools/layover.ts 95.34% <ø> (ø)
js/jupyterlab-deck/src/design.ts 69.38% <69.38%> (ø)
js/jupyterlab-deck/src/tools/base/button.ts 76.47% <76.47%> (ø)
js/jupyterlab-deck/src/tools/manager.ts 82.14% <82.14%> (ø)
js/jupyterlab-deck/src/tools/styleDefaults.ts 84.09% <84.09%> (ø)
js/jupyterlab-deck/src/tools/deckDefaults.ts 91.66% <91.66%> (ø)
js/jupyterlab-deck/src/notebook/plugin.ts 91.83% <91.83%> (ø)
js/jupyterlab-deck/src/tools/base/selector.ts 94.59% <94.59%> (ø)
js/jupyterlab-deck/src/tools/base/slider.ts 95.16% <95.16%> (ø)
... and 12 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@bollwyvl bollwyvl mentioned this pull request Jan 10, 2023
Open
@bollwyvl
Copy link
Contributor Author

bollwyvl commented Feb 6, 2023

Should use this pattern to get updated selections: jupyterlab/jupyterlab#13915

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Tag-based Cell Style UI
1 participant
@bollwyvl