Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Include #11

Open
ghost opened this issue Dec 10, 2018 · 8 comments
Open

Add support for Include #11

ghost opened this issue Dec 10, 2018 · 8 comments

Comments

@ghost
Copy link

ghost commented Dec 10, 2018

The ~/.ssh/config file supports an Include directive to load more config files, making it easier to separate groups of hosts. For example:

# ~/.ssh/config
IdentityFile ~/.ssh/id_rsa
IdentityFile ~/.ssh/id_rsa_work

Include ~/.ssh/config_work
Include ~/.ssh/config_private

Hosts from these Included configuration files should also be shown.

@deanishe
Copy link
Owner

Duplicate of #3, which was attempted in #7.

The workflow uses a 3rd-party library to parse ssh config files. If you can find one that supports Include, I can integrate it.

@ghost
Copy link
Author

ghost commented Dec 11, 2018

Looks like https://github.com/danieljimenez/ssh_config should have supported that, but it doesn't 🤔 Seems he misunderstood how Include works. I'll see if I can get that working.

@deanishe
Copy link
Owner

Yeah, it doesn’t work like it’s supposed to.

Now you bring it up, i should probably revert to the old library with no Include support, rather than one with broken support.

Include support would be awesome. I had another look through the available libs, but none I could find supports it :(

@georgesnow
Copy link

@deanishe I know this is old issue. but I will take a look and see if can figure out recursive ssh configs. doesn't look like anyone else has attempted to figure it out.

@deanishe
Copy link
Owner

Oops. I have a working parser here. I'm afraid I just haven't bothered to tidy it up and integrate it yet.

@ghost
Copy link
Author

ghost commented Oct 28, 2019

Looks like I never got around to that either 🙈

@deanishe would be cool if you could include that!

@ideologysec
Copy link

Any updates on this? I saw a mention elsewhere on your Alfred-Workflows issues (awesome lib btw, thanks very much!) that you're rewriting most things in Python3 - is this Include file support getting deferred until the automation landscape settles down a bit?

@deanishe
Copy link
Owner

is this Include file support getting deferred until the automation landscape settles down a bit?

No, I'm just really busy with work atm. It's not helping that when I look at the workflow's code, I want to rewrite the whole thing…

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants