Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature request] "Old-style" highlighter #494

Open
al-n opened this issue Nov 27, 2022 · 14 comments
Open

[Feature request] "Old-style" highlighter #494

al-n opened this issue Nov 27, 2022 · 14 comments

Comments

@al-n
Copy link

al-n commented Nov 27, 2022

Problem
Sometimes, especially when the different page/trim/crop boxes of PDFs do not align, the highlighter does not select text correctly (see image)
image
Also, equations might get highlighted very annyoingly...

Proposal
Add a new tool, the old-style highlighter, that does not snap to the text, so that one can just "draw" the wanted highlight.

Alternative
Maybe one can also just simply "turn off" the snapping, draw the respective highlights and then turn it back on again? Since I don't have any insight into the inner workings of rM, don't know which one is easier.

Let me know if that is something that could be of interest to other users and/or simple to implement. Thanks <3

@yyamagit
Copy link

I want the old-style highligher too.
The reason is that the highliger does not select Japanese text correctly.
The current text selection algorithm does not work correctly for Japanese,
because, unlike English, Japanese words are not separated by spaces.

Japanese is not officially supported by the remarkable paper.
For this reason, I install Japanese fonts.

@ddvk
Copy link
Owner

ddvk commented Dec 1, 2022

I'll see if something can be done...

@al-n
Copy link
Author

al-n commented Dec 1, 2022

Thanks a lot! Let me know if I can help in any capacity (testing or whatever)!

@ddvk
Copy link
Owner

ddvk commented Dec 5, 2022

update, so far there is one way to
disable it, but no way to toggle it.

@al-n
Copy link
Author

al-n commented Dec 5, 2022

you mean disable it for an entire notebook? or until a restart or something?

@ddvk
Copy link
Owner

ddvk commented Dec 6, 2022

disables it for everything.

the other would be to have the v1 Highlighter be a plain highlighter (but without the additional red/blue colors))

ddvk added a commit that referenced this issue Dec 6, 2022
@ddvk
Copy link
Owner

ddvk commented Dec 6, 2022

so here is something, Highlighter v1 won't snap to the text. to install and test (rm2 2.15.1.1189):
sh -c "$(wget https://raw.githubusercontent.com/ddvk/remarkable-hacks/master/patch.sh -O-)" _ highlighter

the v1 highlits won't be shown when exported from tablet (only from desktop app)

@yyamagit
Copy link

yyamagit commented Dec 7, 2022

I also tried to test it, but when I executed the following command, I got an error.
Note that I am using Version 3.0.4.1292 of RM1. Can I try it?

reMarkable: ~/ sh -c "$(wget https://raw.githubusercontent.com/ddvk/remarkable-hacks/master/patch.sh -O-)" _ highlighter
Connecting to raw.githubusercontent.com (185.199.108.133:443)
wget: note: TLS certificate validation not implemented
writing to stdout
-                    100% |*********************************************************************************************************************************************************************************************| 13316  0:00:00 ETA
written to stdout
Less than 3MB free, 2MB
Trying to free space...
Vacuuming done, freed 0B of archived journals from /var/log/journal.
Vacuuming done, freed 0B of archived journals from /var/log/journal/255c56649b604686a1067cdd4c937947.
Less than 3MB free, 2MB
Aborting...

@Eeems
Copy link
Contributor

Eeems commented Dec 7, 2022

I think you missed the part where this was for the rM2 and 2.15.

You'll find that third party software for the reMarkable usually doesn't target the beta versions of the OS due to the EULA for the beta you agreed to not permitting third party software.

@yyamagit
Copy link

yyamagit commented Dec 8, 2022

I found that I could not try. Thanks for the response.

@al-n
Copy link
Author

al-n commented Dec 19, 2022

Oh damnit, I just got back from holidays to test this and now I realized im running 3.0.4.1305 :(
I'll see what I can do to test, but for now it looks like I have to wait for the patch for the new version, so I'm happy to test afterwards!

@al-n
Copy link
Author

al-n commented Dec 19, 2022

So I downgraded to 2.15.1.1189, but when I use the shellscript I get a 404 error:

Connecting to raw.githubusercontent.com (185.199.111.133:443)
wget: note: TLS certificate validation not implemented
writing to stdout
-                    100% |*****************************************************************************************************************************************************************| 13316  0:00:00 ETA
written to stdout
Disk space seems to be enough.
rM2 Version 2.15.1.1189 - highlighter
Connecting to github.com (140.82.121.3:443)
wget: note: TLS certificate validation not implemented
wget: server returned error: HTTP/1.1 404 Not Found

@ddvk
Copy link
Owner

ddvk commented Dec 20, 2022

coulde be: patch_highlighter

@al-n
Copy link
Author

al-n commented Dec 22, 2022

Thanks for this! So functionality is exactly what is needed. Only thing: When highlighting, the color does not change immediately to the desired one - usually if you stop the brush-stroke you are doing, after a second or so the screen refreshes with the correct shade of gray, but with the highlighter v1 it does only show the correct shades after a screen refresh is triggered by something elese (e.g. a menu overlapping with the stroke disappearing or a complete page redraw).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants