Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export To Systemd #664

Closed
jasonivers opened this issue Jan 20, 2017 · 8 comments
Closed

Export To Systemd #664

jasonivers opened this issue Jan 20, 2017 · 8 comments
Labels

Comments

@jasonivers
Copy link

When I have a .env file, foreman is ending up with ExecStart on the Environment line, like this:

Environment="PATH=/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/games:/usr/local/games" "RAILS_ENV=uat" "RACK_ENV=uat" ExecStart=/bin/bash -lc 'bash -lic 'bin/sidekiq''

This breaks restarting it. It should be:

Environment="PATH=/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/games:/usr/local/games" "RAILS_ENV=uat" "RACK_ENV=uat" ExecStart=/bin/bash -lc 'bash -lic 'bin/sidekiq''

@timurb
Copy link
Contributor

timurb commented Jan 24, 2017

@jasonivers I think you've mistyped the "it should be" part.
It should be something like the following instead (at least it was like that in my setup with foreman 0.82):

Environment=PATH=/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/games:/usr/local/games
Environment=RAILS_ENV=uat
Environment=RACK_ENV=uat
ExecStart=/bin/bash -lc 'bash -lic bin/sidekiq'

I see exactly the same issue for the few recent days.

@timurb
Copy link
Contributor

timurb commented Jan 24, 2017

I guess this commit introduced regression: c7edf64

No idea if this one contributed to that too: #652

@ddollar
Copy link
Owner

ddollar commented Jan 24, 2017

Anyone up for writing a patch and a test case so this doesn't regress again?

@timurb
Copy link
Contributor

timurb commented Jan 24, 2017 via email

@yelhouti
Copy link

Thanks guys for the great work, you might want to remove the gem 0.83 since you removed the release from git

@dunyakirkali
Copy link

When can we expect this to be released?

@jasonivers
Copy link
Author

Thank you for coding the fix... will it be released any time soon?

@ddollar ddollar added the bug label Mar 27, 2017
@rilian
Copy link

rilian commented Apr 7, 2017

thank you so much 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

6 participants