-
Notifications
You must be signed in to change notification settings - Fork 629
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Would be useful to provide a "foreman stop" command #156
Comments
How would If you have a good plan for this, I'd consider this pull request. |
A somewhat related issue is #235. |
Possibly related to #384... A
The |
Why was this closed? |
Foreman is designed to be run in the foreground. This feature would add a lot of complexity (how do we know which foreman to stop) for something outside the primary use case. |
I know it is a old one, but I have to clear some state after ^C occurs. Hence I googled this ticket. he state is a PID file that I need to get out of the way. |
Having the exact same problem as @sebs and would really like a fix for this. I'm using Foreman for the dev environment for a React + Electron desktop app (per the recommendation of this article) where I start a dev server at localhost:5000. When I hit ctrl-C Foreman quits, but it leaves the server running and still listening at :5000, meaning that when I attempt to start my Foreman service again it throws an error because there is already another process listening to :5000. Is there a way to terminate all child processes from the interactive prompt? |
My Scenario: I start a docker environment with forman start
.... executes docker-compose up --build I I use STG+C and in one of 1000 cases, the docker magic fails. Let it be a filehandle open blocking a shutdown of your app or a db connection. So I would love to have a stupid list of forman stop to clean all the state that I want to clean. Just in case. In my case, this would be a
@axelkennedal make sure your dev server processes all the important events for exiting the shell. most dev servers are just dev servers. I would expect the server not to terminate because of open connections that still do io. Long running request etc come in mind. On one side this is: go fix electron and not foreman for a faulty implementation. On the other side, I would love to see the tool for these faulty scenarios in foreman. Hope all this makes sense. |
In the case where you're in another terminal, or have backgrounded the foreman process with
&
(which I plan to do inside of a Jenkins job), it would be useful to have aforeman stop
stop the process the same way that aCtrl+C
might workThe text was updated successfully, but these errors were encountered: