Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

observedAttributes on src and reset #15

Open
muan opened this issue Sep 13, 2023 · 0 comments · May be fixed by #17
Open

observedAttributes on src and reset #15

muan opened this issue Sep 13, 2023 · 0 comments · May be fixed by #17
Labels
bug Something isn't working

Comments

@muan
Copy link
Member

muan commented Sep 13, 2023 •
edited

#14 (comment)

I do think observedAttributes and attributeChangedCallback are necessary, but we might be able to tackle that in another PR considering that it'll include some lifecycle resetting.

Currently setting src does not do anything. It should reset initialize the open-stroies element.

I believe this will be needed for to support React currently without experimental flag. Even though I don't think it really matters to me. 😬 Regardless now that we have setters and content attribute changes the element should definitely observe it.
@muan muan added the bug Something isn't working label Sep 13, 2023
@muan muan mentioned this issue Sep 13, 2023
Merged
@muan muan linked a pull request Oct 4, 2023 that will close this issue
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add observedAttributes dddddddddzzzz/open-stories-element
1 participant
@muan