Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adjust to dsp-api v25.0.0 #218

Closed
loicjaouen opened this issue Dec 12, 2022 · 4 comments
Closed

adjust to dsp-api v25.0.0 #218

loicjaouen opened this issue Dec 12, 2022 · 4 comments
Assignees

Comments

@loicjaouen
Copy link
Member

dsp-api v25.0.0 release introduced a breaking change:

change all project IRIs to contain UUID instead of shortcode (DEV-1400) (dasch-swiss/dsp-api#2255)

Breaking change means that we have to adjust on our side too.

@loicjaouen
Copy link
Member Author

the project's IRI used to be:

  • http://rdfh.ch/projects/0103, it will now be:
  • http://rdfh.ch/projects/GTsqfu_hQR61SayOgcIXrg

a quick review of the code: https://github.com/LaDHUL/Theatre-de-societe/search?q=http%3A%2F%2Frdfh.ch%2Fprojects%2F0103

shows that the projec's code:

  • is not used in the application itself
  • used to be used in the cache builder but it is not anymore
  • remains in the turtle files that are not the code authoritative source anymore

@loicjaouen
Copy link
Member Author

=> nothing to change, nothing to do

Really? probably, but let's test on ls-test where this v25 has been released

  • testing the app => it is working fine
  • running the cache builder script => it is working fine too

@loicjaouen loicjaouen self-assigned this Dec 12, 2022
@loicjaouen
Copy link
Member Author

possible blind spots:

  • the project's IRI might be build from the prefix
    • searching for 0103 didn't bring anything looking at risk,
    • it would be used with the property attachedToProject which did not bring anything problematic usage either
  • the data itself heavily relies on project ID, as well as meta data, like users are attached to projects, the DaSCH should move take care of that in the migration and it looks fine, requests like these ones give the same number of results:
    PREFIX knora-base: <http://www.knora.org/ontology/knora-base#>
    PREFIX rdfs: <http://www.w3.org/2000/01/rdf-schema#>
    PREFIX knora-admin: <http://www.knora.org/ontology/knora-admin#>
    select
      (count(?s) as ?c)
      #(count(?p) as ?d)
      #(count(?pp) as ?e)
      #(count(?oo) as ?f)
    where {
      bind(<http://rdfh.ch/projects/GTsqfu_hQR61SayOgcIXrg> as ?project)
      #bind(<http://rdfh.ch/projects/0103> as ?project)
      ?s ?p ?project .
    #  ?project ?pp ?oo.
    }

@loicjaouen
Copy link
Member Author

next update is on friday when the release is due

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant